Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENG-14573: Add knowledge of mask_all_occurrences config field #580

Merged
merged 5 commits into from
Nov 27, 2024
Merged

ENG-14573: Add knowledge of mask_all_occurrences config field #580

merged 5 commits into from
Nov 27, 2024

Conversation

juniocezar
Copy link
Member

Description of the change

ENG-14573: Add knowledge of mask_all_occurrences config field

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Jira issue referenced in commit message and/or PR title

@juniocezar juniocezar requested a review from wcmjunior November 25, 2024 17:49
wcmjunior
wcmjunior reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@wcmjunior wcmjunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments below:

cyral/internal/repository/confanalysis/resource.go Outdated Show resolved Hide resolved
cyral/internal/repository/confanalysis/resource.go Outdated Show resolved Hide resolved
docs/resources/repository_conf_analysis.md Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@juniocezar juniocezar requested a review from wcmjunior November 26, 2024 15:25
wcmjunior
wcmjunior approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@wcmjunior wcmjunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYVM @juniocezar !

@wcmjunior wcmjunior merged commit 39635f2 into main Nov 27, 2024
2 checks passed
@wcmjunior wcmjunior deleted the ENG-14573 branch November 27, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wcmjunior wcmjunior wcmjunior approved these changes

@cyral-bot cyral-bot Awaiting requested review from cyral-bot cyral-bot is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juniocezar @wcmjunior